-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
we can't have profiles because we are also in the rustc worksapce #637
Conversation
Argh, what's with Travis' mac builder? |
Wait, what? Since when is this repo in the rust-lang org? Is that connected with our mac builders being screwed up? |
Since yesterday evening. Yea, ci is still messed up, but it's being worked on |
Well, this blocks rust-lang/rust#58535 |
Can you force push this branch to get the build started on travis-ci.com @RalfJung? Thanks! |
Cycling the PR should usually do it. |
Hm, it started a new build that works but the old build is still around and blocks merging? Could it be that the repo settings need to be adjusted to "require" the right thing to pass? Is there a way @oli-obk and/or me could get enough powers in this repo to configure such things? |
Yeah, the issue is that the GitHub UI allows you to block on a check only when it successfully completed, so I was waiting for it to finish before switching the block. Reconfigured it to block on both AppVeyor and the new Travis.
Yeah, I can give them to both of you, but do you change those settings often? We'd prefer to avoid giving admin perms when not necessary, but it's fine if you need them. |
Not really. We'll likely ask you to set up bors some time soon-ish and that's it. So, yeah, not having admin powers is also fine. |
Otherwise we get