support panic=abort #1549
Merged
support panic=abort #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
reviewed
Sep 18, 2020
| .expect("No panic runtime found!"); | ||
| let panic_runtime = tcx.crate_name(*panic_runtime); | ||
| // This replicates some of the logic in `inject_panic_runtime`. | ||
| // FIXME: is there a way to reuse that logic? |
There was a problem hiding this comment.
we could have a start_panic_instance function on Session in rustc
There was a problem hiding this comment.
Or maybe we could somehow figure out "which crate that was added as a dependency is the panic runtime". I thought that's what the previous code was doing, but it still saw the panic_unwind crate even with -C panic=abort so clearly that was not the right approach.
oli-obk
reviewed
Sep 18, 2020
oli-obk
approved these changes
Sep 18, 2020
|
@bors r=oli-obk |
|
📌 Commit 97a71c0 has been approved by |
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for abort-on-panic (#1058). To achieve this, we insert
cargo-miriasRUSTCwhen building the standard library, and patch the rustc flags in a way similar to what bootstrap does.However, this is currently not supported on Windows as the Windows code uses inline assembly to cause an abort (?!?). I'll submit a rustc PR with some
cffg(miri)to make that work. (EDIT: that would be rust-lang/rust#76871)Cc @Aaron1011 r? @oli-obk