Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead Intel intrinsics #3691

Closed
RalfJung opened this issue Jun 20, 2024 · 0 comments · Fixed by #3747
Closed

Remove dead Intel intrinsics #3691

RalfJung opened this issue Jun 20, 2024 · 0 comments · Fixed by #3747
Labels
A-intrinsics Area: Affects out implementation of Rust intrinsics C-cleanup Category: cleaning up our code

Comments

@RalfJung
Copy link
Member

Since rust-lang/stdarch#1584 there are some LLVM intel intrinsics that stdarch does not use any more, making them dead code in Miri. Might be a good idea to clean that up. :)

(I also wonder whether there's some good way to check, in the future, that we don't have other dead untested vendor intrinsics... maybe something that checks line coverage or so?)
@RalfJung RalfJung mentioned this issue Jun 20, 2024
Merged
@RalfJung RalfJung mentioned this issue Jul 13, 2024
Merged
@RalfJung RalfJung added C-cleanup Category: cleaning up our code A-intrinsics Area: Affects out implementation of Rust intrinsics labels Jul 13, 2024
bors added a commit that referenced this issue Aug 7, 2024
@bors
Auto merge of #3747 - RalfJung:sse-cleanup, r=RalfJung
0537b14 
remove some SSE/SSE2 intrinsics that are no longer used by stdarch

Fixes #3691
@bors bors closed this as completed in 2ae377f Aug 7, 2024
RalfJung pushed a commit to RalfJung/rust that referenced this issue Aug 10, 2024
@bors
Auto merge of rust-lang#3747 - RalfJung:sse-cleanup, r=RalfJung
05534a3 
remove some SSE/SSE2 intrinsics that are no longer used by stdarch

Fixes rust-lang/miri#3691
RalfJung pushed a commit to RalfJung/rust that referenced this issue Aug 18, 2024
@bors
Auto merge of rust-lang#3747 - RalfJung:sse-cleanup, r=RalfJung
2f405eb 
remove some SSE/SSE2 intrinsics that are no longer used by stdarch

Fixes rust-lang/miri#3691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-intrinsics Area: Affects out implementation of Rust intrinsics C-cleanup Category: cleaning up our code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove some SSE/SSE2 intrinsics that are no longer used by stdarch RalfJung/miri
1 participant
@RalfJung