-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a --chapter option to mdbook test. #1741
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f0189cd
add a --chapter option to mdbook test.
clovett 4d78119
fix unit tests
clovett bf6d452
fix expected output
clovett 71e490d
move command line parsing code and make test output comparison agnost…
clovett 6e3d275
Merge branch 'master' into clovett/chapters
clovett 99a8c0d
CR feedback, switch to Option<&str> for chatper parameter.
clovett f1c07b0
Fix tests
clovett ed0ee85
Merge branch 'master' into clovett/chapters
clovett 96245d2
fix: unit test expected output has changed.
clovett 7c55869
fix: fmt --check
clovett 0926c52
fix: add test_chapter method so test can remain api compatible.
lovettchris 05ed667
doc: add documentation of new --chapter option.
clovett 601b6df
doc: fix typo.
clovett 20cca38
fix: remove redundant check.
clovett 5ec488c
doc: add clarifying comments.
clovett 9172005
Merge branch 'master' into clovett/chapters
clovett c1004f7
fix: revert changes from code review.
clovett e979012
fix: cr feedback no need to unwrap Option<&str> when comparing chapte…
clovett d383ae0
Merge branch 'clovett/chapters' of github.com:clovett/mdBook into clo…
clovett 4ead38f
fix: code review comments.
clovett 1747094
fix: code review cleanup
clovett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little unclear to me on what happens if
chapter
is None. Can it include a little more explanation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing, I added clarifying comments
// test_chapter with chapter:None will run all tests.
and on thetest_chapter
function itself the doc comment:/// If
chapteris
None, all tests will be run.