Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacers in sidebar don't appear at correct level #733

Closed
mattico opened this issue Jul 24, 2018 · 5 comments · Fixed by #2364
Closed

Spacers in sidebar don't appear at correct level #733

mattico opened this issue Jul 24, 2018 · 5 comments · Fixed by #2364
Labels
A-HTML Area: HTML Rendering A-Summary Area: The summary page, organization of pages.

Comments

@mattico
Copy link
Contributor

mattico commented Jul 24, 2018

For example, the spacer in SUMMARY.md is placed inside the subsection list, when it should be top-level:

image

@mattico mattico added the A-HTML Area: HTML Rendering label Jul 24, 2018
@mattico mattico self-assigned this Jul 24, 2018
@mickvangelderen
Copy link

Just noticed this. Still happening.

@ehuss ehuss added the A-Summary Area: The summary page, organization of pages. label Jun 1, 2022
@ehuss
Copy link
Contributor

ehuss commented Jun 1, 2022

Copying my comment from #1730:

I suspect it would be around here, where it uses an <li> for the spacer. Perhaps it could use a different tag, like <hr>? However, this would need careful consideration of how it will change existing users, and whether or not it will affect their expected rendering.

@mattico mattico removed their assignment Jun 2, 2022
@alek3y
Copy link

alek3y commented Feb 20, 2023

It seems like the <li> spacer is rendered as a child of the previous section (which also causes it to disappear when folding is enabled), so I think <hr> would be bound by the .section's padding-left either way.

Maybe, a workaround could be to delay this call (and remove the continue, since it seems to also break the next sections) to when current_level is back to 1 (possibly here, but it might bug when this runs).

This would force it to render inside .chapter and not inside li > .section, which would also fix its indentation.

@expikr
Copy link
Contributor

expikr commented May 17, 2024

Fixed by #2364

@ehuss
Copy link
Contributor

ehuss commented May 17, 2024

Thanks! I'm not sure why it didn't auto-close.

@ehuss ehuss closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-HTML Area: HTML Rendering A-Summary Area: The summary page, organization of pages.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants