-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary separators rendered with incorrect indentation #1730
Comments
@ehuss happy to take a stab at this, but I'm not sure where to start. Any pointers would be appreciated. |
I suspect it would be around here, where it uses an |
I'm not sure if "me too" comments are appreciated, but I've noticed the same thing. Nobody reading my docs has mentioned it though, so I just figured it was just my "perfectionism" again (I tend to wrestle with the whole "perfect is the enemy of good" thing quite a bit). FWIW I would suggest having the indendation of the separator bar in the HTML, somehow match the indentation of the first Either that, or just make separator bars always start from the left margin -- this seems like it might be simpler, but I haven't looked at it in detail so I can't say for sure. If I were more familiar with Rust (and had the time) I would have a go at fixing it myself. |
This seems to be a duplicate of #733 |
Indeed it looks to be a duplicate, thanks! |
Thanks for the awesome tool.
One issue I noticed, considering the following
SUMMARY.md
separators feature:Separators are using the indentation of the block before it, not after it, which is incorrect in this case:
Which is rendered like this:
I suggest calculating the indentation from the entry after it, not before it, in order to fix this behavior.
The text was updated successfully, but these errors were encountered: