Skip to content

Commit

Permalink
Escape <> in rendered toc
Browse files Browse the repository at this point in the history
  • Loading branch information
dtolnay committed Nov 9, 2020
1 parent eaa6914 commit c712ba7
Showing 1 changed file with 18 additions and 2 deletions.
20 changes: 18 additions & 2 deletions src/renderer/html_handlebars/helpers/toc.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
use std::collections::BTreeMap;
use std::io;
use std::path::Path;

use crate::utils;
Expand Down Expand Up @@ -102,7 +103,7 @@ impl HelperDef for RenderToc {
// Part title
if let Some(title) = item.get("part") {
out.write("<li class=\"part-title\">")?;
out.write(title)?;
write_escaped(out, title)?;
out.write("</li>")?;
continue;
}
Expand Down Expand Up @@ -160,7 +161,7 @@ impl HelperDef for RenderToc {
html::push_html(&mut markdown_parsed_name, parser);

// write to the handlebars template
out.write(&markdown_parsed_name)?;
write_escaped(out, &markdown_parsed_name)?;
}

if path_exists {
Expand Down Expand Up @@ -204,3 +205,18 @@ fn write_li_open_tag(
li.push_str("\">");
out.write(&li)
}

fn write_escaped(out: &mut dyn Output, mut title: &str) -> io::Result<()> {
let needs_escape: &[char] = &['<', '>'];
while let Some(next) = title.find(needs_escape) {
out.write(&title[..next])?;
match title.as_bytes()[next] {
b'<' => out.write("&lt;")?,
b'>' => out.write("&gt;")?,
_ => unreachable!(),
}
title = &title[next + 1..];
}
out.write(title)?;
Ok(())
}

0 comments on commit c712ba7

Please sign in to comment.