Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.2] Backports #4284

Merged
merged 5 commits into from
Feb 23, 2025
Merged

[0.2] Backports #4284

merged 5 commits into from
Feb 23, 2025

Conversation

@rustbot
Copy link
Collaborator

rustbot commented Feb 22, 2025

@tgross35: no appropriate reviewer found, use r? to override

@rustbot
Copy link
Collaborator

rustbot commented Feb 22, 2025

Some changes occurred in the Android module

cc @maurer

Жунёва Мария Михайловна and others added 5 commits February 22, 2025 23:34
(backport <rust-lang#3756>)
(cherry picked from commit 187468d)
(backport <rust-lang#4268>)
(cherry picked from commit eec39f5)
wait(2p)[^1] says

> WEXITSTATUS(status)
>         If WIFEXITED(status) is true, evaluates to the low-order 8 bits
>         of the argument passed to _exit(2) or exit(3) by the child.

meaning WEXITSTATUS(status) is an 8-bit value.  We accidentally return
too many bits. For example WEXITSTATUS(-1) returns -1 instead of 255.

Fix it, matching the C library and our other WEXITSTATUS implementations.

[^1] https://manpage.me/index.cgi?apropos=0&q=wait&sektion=2&manpath=FreeBSD+12-CURRENT+and+Ports&arch=default&format=html

Originally reported at fish-shell/fish-shell#10919

(backport <rust-lang#4213>)
(cherry picked from commit f9cde2f)
`ctest` is very particular about this and the current configuration,
though working most of the time, seems to cause occasional CI errors
that can't easily be explained or mitigated. Switch back to matching all
Apple `target_os` options until `ctest` is fixed.

(backport <rust-lang#4282>)
(cherry picked from commit a986f81)
@tgross35 tgross35 enabled auto-merge February 22, 2025 23:34
@tgross35 tgross35 added this pull request to the merge queue Feb 22, 2025
Merged via the queue into rust-lang:libc-0.2 with commit 0d2ea3c Feb 23, 2025
44 checks passed
@tgross35 tgross35 deleted the backport-oysters branch February 23, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants