[solaris/illumos] add SIGRTMIN and SIGRTMAX #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add these functions, similar to the Linux ones. Also add tests. For illumos, the source code is at [1] and documentation is at [2]. Blame suggests that Solaris also supports the same calls. [1]: https://github.com/illumos/illumos-gate/blame/27ecbff00d8c86a2647d6fe325cacb220d712115/usr/src/uts/common/sys/iso/signal_iso.h#L100-L101 [2]: https://illumos.org/man/3HEAD/signal.h
tgross35
approved these changes
Dec 3, 2024
|
Thanks for the quick review :D |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Dec 9, 2024
Add these functions, similar to the Linux ones. Also add tests. For illumos, the source code is at [1] and documentation is at [2]. Blame suggests that Solaris also supports the same calls. [1]: https://github.com/illumos/illumos-gate/blame/27ecbff00d8c86a2647d6fe325cacb220d712115/usr/src/uts/common/sys/iso/signal_iso.h#L100-L101 [2]: https://illumos.org/man/3HEAD/signal.h (backport <rust-lang#4171>) (cherry picked from commit a8aaadf)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add these functions, similar to the Linux ones. Also add tests.
Sources
For illumos, the source code is at 1 and documentation is at 2. Blame suggests that Solaris also supports the same calls.
The comment about "no placeholder values" doesn't really apply in this case, just like on Linux, because
SIGRTMAXis a dynamic function call.Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI