-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for sparc64 on OpenBSD #1470
Conversation
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
@bors delegate=semarie cc @asomers in case you want to review - otherwise, @semarie if this doesn't break anything on our end, and it works for OpenBSD, i'm fine with it. My only request is for you to add this particular target to |
✌️ @semarie can now approve this pull request |
@gnzlbg hey. I missed the addition in |
@bors: r+ |
📌 Commit 5e78ab9 has been approved by |
add support for sparc64 on OpenBSD
@gnzlbg I see |
You can comment it here for now, and uncomment it once you have added a rustc_target specification for the target. Ideally there would at least be a PR for that before merging this. |
5e78ab9
to
1a45839
Compare
I removed the commit adding Waiting the PR in rustc is possible, but I expected to do one PR in rustc, and not one for the target and another for updating libc. I am preparing a PR for rustc. |
@bors: r+ I trust you on this, you have done this before. |
📌 Commit 1a45839 has been approved by |
add support for sparc64 on OpenBSD
💥 Test timed out |
@bors retry |
add support for sparc64 on OpenBSD
☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
No description provided.