Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for sparc64 on OpenBSD #1470

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Aug 15, 2019

No description provided.

@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@gnzlbg
Copy link
Contributor

gnzlbg commented Aug 15, 2019

@bors delegate=semarie

cc @asomers in case you want to review - otherwise, @semarie if this doesn't break anything on our end, and it works for OpenBSD, i'm fine with it.

My only request is for you to add this particular target to ci/build.sh at some point to make sure that this target at least builds correctly.

@bors
Copy link
Contributor

bors commented Aug 15, 2019

✌️ @semarie can now approve this pull request

@semarie
Copy link
Contributor Author

semarie commented Aug 15, 2019

@gnzlbg hey. I missed the addition in ci/build.sh. It should be fine now.

@gnzlbg
Copy link
Contributor

gnzlbg commented Aug 15, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 15, 2019

📌 Commit 5e78ab9 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Aug 15, 2019

⌛ Testing commit 5e78ab9 with merge d8f173e...

bors added a commit that referenced this pull request Aug 15, 2019
add support for sparc64 on OpenBSD
@semarie
Copy link
Contributor Author

semarie commented Aug 15, 2019

@gnzlbg I see style-and-doc test failed because the target is unknown. should I postpone the inclusion of sparc64-unknown-openbsd for after support was added to rustc ?

@gnzlbg
Copy link
Contributor

gnzlbg commented Aug 15, 2019

You can comment it here for now, and uncomment it once you have added a rustc_target specification for the target. Ideally there would at least be a PR for that before merging this.

@semarie
Copy link
Contributor Author

semarie commented Aug 15, 2019

I removed the commit adding openbsd-unknown-sparc64 in ci/build.sh. Commenting wasn't a solution as it was a part of a shell variable. It will be readded later.

Waiting the PR in rustc is possible, but I expected to do one PR in rustc, and not one for the target and another for updating libc. I am preparing a PR for rustc.

@gnzlbg
Copy link
Contributor

gnzlbg commented Aug 15, 2019

@bors: r+

I trust you on this, you have done this before.

@bors
Copy link
Contributor

bors commented Aug 15, 2019

📌 Commit 1a45839 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Aug 15, 2019

⌛ Testing commit 1a45839 with merge 9f57797...

bors added a commit that referenced this pull request Aug 15, 2019
add support for sparc64 on OpenBSD
@bors
Copy link
Contributor

bors commented Aug 15, 2019

💥 Test timed out

@semarie
Copy link
Contributor Author

semarie commented Aug 15, 2019

@bors retry

@bors
Copy link
Contributor

bors commented Aug 15, 2019

⌛ Testing commit 1a45839 with merge dab1050...

bors added a commit that referenced this pull request Aug 15, 2019
add support for sparc64 on OpenBSD
@bors
Copy link
Contributor

bors commented Aug 15, 2019

☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing dab1050 to master...

@bors bors merged commit 1a45839 into rust-lang:master Aug 15, 2019
@semarie semarie deleted the openbsd-sparc64 branch August 16, 2019 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants