-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FreeBSD #1467
Fix FreeBSD #1467
Conversation
@gnzlbg: no appropriate reviewer found, use r? to override |
/AzurePipelines run |
No pipelines are associated with this pull request. |
/AzurePipelines run rust-lang.libc |
No pipelines are associated with this pull request. |
@carllerche thank you for reporting this issue. Would you be able to try the libc branch used by this PR and let us know whether the issue is resolved ? You would need to amend the libc dependency in your Cargo.toml with: libc = { version = "0.2", git = "https://github.com/gnzlbg/libc/", branch = "fix_freebsd" } |
/AzurePipelines run |
No pipelines are associated with this pull request. |
Removing the |
I'm not sure what you mean by:
|
I mean, that I misread the patch, sorry. The patch is explicitly forcing |
@bors: r+ |
📌 Commit f081694 has been approved by |
Fix FreeBSD #1440 broke FreeBSD by changing `libc` FreeBSD targets to require a `cfg(freebsdXX)` to be defined, but not updating `build.rs` to define `freebsd11` when `LIBC_CI` is not available. Since `LIBC_CI` is always defined on CI, this issue went undetected. This PR fixes that issue in the `build.rs` and introduces a build task that tests FreeBSD without `LIBC_CI` on FreeBSD11, although I'm not sure this would have caught the issue in #1466 . Closes #1466 .
☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
#1440 broke FreeBSD by changing
libc
FreeBSD targets to require acfg(freebsdXX)
to be defined, but not updatingbuild.rs
to definefreebsd11
whenLIBC_CI
is not available. SinceLIBC_CI
is always defined on CI, this issue went undetected.This PR fixes that issue in the
build.rs
and introduces a build task that tests FreeBSD withoutLIBC_CI
on FreeBSD11, although I'm not sure this would have caught the issue in #1466 .Closes #1466 .