Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module for bare metal architecture which still have a libc #1102

Closed
wants to merge 3 commits into from

Conversation

gbip
Copy link

@gbip gbip commented Oct 20, 2018

This should fix #375 😄
Please tell me if there is anything wrong in this PR.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gbip
Copy link
Author

gbip commented Oct 28, 2018

I think this is now ready for review 😄

@alexcrichton
Copy link
Member

Thanks for the PR! This has come up a few times before:

Right now libc isn't targeted at providing a compatibility layer or polyfilling certain types and such on various platforms, but rather it's providing the bindings for a particular platform that match the C standard and/or popular C compilers. That means that we can't really add this target as it doesn't really match up to existing compilers as there's not really a concept of "no platform".

@gbip
Copy link
Author

gbip commented Oct 29, 2018

Could you please join the discussion in #375 ?

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 5, 2018

@gbip Thank you for submitting this PR! I am going to close this PR since it appears that a change like this would require more consensus. Feel free to re-open if you disagree, or after more consensus is achieved.

@gnzlbg gnzlbg closed this Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The thumb* target family (which have newlib libc) are not supported
4 participants