-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add size != stride to frequently requested changes #216
Conversation
Could you add some language here explaining the implications for objects that set their alignment greater than their size would normally be? |
@rfcbot merge |
Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. |
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Should we consider cross-referencing the other discussions that the project has had on this topic, if only to make it easier for people reading these docs to find past discussions about the matter? I'm thinking specifically of: |
There's also rust-lang/unsafe-code-guidelines#176. |
@rfcbot reviewed |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
Co-authored-by: scottmcm <scottmcm@users.noreply.github.com>
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
No description provided.