Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size != stride to frequently requested changes #216

Merged
merged 7 commits into from
Oct 18, 2023

Conversation

carbotaniuman
Copy link
Contributor

No description provided.

@joshtriplett
Copy link
Member

Could you add some language here explaining the implications for objects that set their alignment greater than their size would normally be?

@joshtriplett
Copy link
Member

@rfcbot merge

@rfcbot
Copy link
Collaborator

rfcbot commented Aug 29, 2023

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period disposition-merge The FCP starter wants to merge (accept) this labels Aug 29, 2023
carbotaniuman and others added 3 commits August 28, 2023 22:42
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
@pnkfelix
Copy link
Member

Should we consider cross-referencing the other discussions that the project has had on this topic, if only to make it easier for people reading these docs to find past discussions about the matter?

I'm thinking specifically of:

@RalfJung
Copy link
Member

There's also rust-lang/unsafe-code-guidelines#176.

@nikomatsakis
Copy link
Contributor

@rfcbot reviewed

@rfcbot rfcbot added final-comment-period The FCP has started, most (if not all) team members are in agreement and removed proposed-final-comment-period labels Aug 29, 2023
@rfcbot
Copy link
Collaborator

rfcbot commented Aug 29, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

carbotaniuman and others added 2 commits August 30, 2023 01:37
Co-authored-by: scottmcm <scottmcm@users.noreply.github.com>
@rfcbot rfcbot added finished-final-comment-period to-announce Not yet announced MCP proposals and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Sep 8, 2023
@rfcbot
Copy link
Collaborator

rfcbot commented Sep 8, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@nikomatsakis nikomatsakis merged commit e686b02 into rust-lang:master Oct 18, 2023
@carbotaniuman carbotaniuman deleted the patch-1 branch October 18, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge The FCP starter wants to merge (accept) this finished-final-comment-period T-lang to-announce Not yet announced MCP proposals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants