Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Fixing the currently-inverted logic in is_new_contributor #129

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Fixing the currently-inverted logic in is_new_contributor #129

merged 1 commit into from
Apr 10, 2018

Conversation

davidalber
Copy link
Collaborator

The logic in is_new_contributor is currently backwards (i.e., it is returning True for existing contributors). You can see Highfive sending the welcome message to an existing contributor in rust-lang/rust#49795, for example.

This PR inverts the logic so that is_new_contributor returns True for new contributors and False for existing contributors.

@nrc nrc merged commit 74079c4 into rust-lang:master Apr 10, 2018
@nrc
Copy link
Member

nrc commented Apr 10, 2018

Thanks!

@davidalber davidalber deleted the fixing-is-new-contributor-logic branch April 10, 2018 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidalber @nrc