-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate futures-stable into futures crate. #854
Conversation
futures-stable provides adapters to work with futures that contain internal self-references. futures-stable only works on nightly. A new nightly feature is added to futures to turn futures-stable on. The futures-stable items are re-exported from the `stable` submodule. Also on nightly only, Future and Stream are implemented for PinBoxes of futures and streams.
cc @cramertj |
This looks great! Thanks! i'll merge once travis is happy. |
Tests are failing because |
Turned nightly off by default in futures-stable, which should get tests to pass (this is unfortunate, since futures-stable does nothing unless nightly is turned on. But futures-stable is unfortunate in general) |
SGTM. There's a precedent for this in |
Yea thats fine, the unfortunate part is that |
Yeah, that is annoying. |
futures-stable provides adapters to work with futures that contain
internal self-references.
futures-stable only works on nightly. A new nightly feature is
added to futures to turn futures-stable on. The futures-stable
items are re-exported from the
stable
submodule.Also on nightly only, Future and Stream are implemented for
PinBoxes of futures and streams.