Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate futures-stable into futures crate. #854

Merged
merged 3 commits into from
Mar 10, 2018

Conversation

withoutboats
Copy link

futures-stable provides adapters to work with futures that contain
internal self-references.

futures-stable only works on nightly. A new nightly feature is
added to futures to turn futures-stable on. The futures-stable
items are re-exported from the stable submodule.

Also on nightly only, Future and Stream are implemented for
PinBoxes of futures and streams.

futures-stable provides adapters to work with futures that contain
internal self-references.

futures-stable only works on nightly. A new nightly feature is
added to futures to turn futures-stable on. The futures-stable
items are re-exported from the `stable` submodule.

Also on nightly only, Future and Stream are implemented for
PinBoxes of futures and streams.
@withoutboats
Copy link
Author

cc @cramertj

@cramertj
Copy link
Member

cramertj commented Mar 9, 2018

This looks great! Thanks! i'll merge once travis is happy.

@withoutboats
Copy link
Author

Tests are failing because cargo test --all in the workspace root can't figure out that we want pin-api with default features turned off. Trying to figure out how to make that work.

@withoutboats
Copy link
Author

withoutboats commented Mar 9, 2018

Turned nightly off by default in futures-stable, which should get tests to pass (this is unfortunate, since futures-stable does nothing unless nightly is turned on. But futures-stable is unfortunate in general)

@cramertj
Copy link
Member

this is unfortunate, since futures-stable does nothing unless nightly is turned on. But futures-stable is unfortunate in general

SGTM. There's a precedent for this in futures-channel, which is entirely cfg'd out when the std feature is disabled.

@cramertj cramertj merged commit e51c515 into rust-lang:0.2 Mar 10, 2018
@withoutboats
Copy link
Author

There's a precedent for this in futures-channel, which is entirely cfg'd out when the std feature is disabled.

Yea thats fine, the unfortunate part is that nightly is not a default feature in futures-stable. Ideally, if you depended directly on futures-stable, by default it would have all the nightly-only items in it.

@cramertj
Copy link
Member

Yeah, that is annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants