Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve unnecessary map_or Clippy issue #2904

Merged

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jan 2, 2025

(as suggested by Clippy nightly)

(as suggested by Clippy nightly)
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit b1bfda0 into rust-lang:master Jan 12, 2025
23 of 24 checks passed
@taiki-e
Copy link
Member

taiki-e commented Jan 12, 2025

Hmm... there is still a clippy issue as the new lint triggered due to MSRV increasing by #2907.

error: initializer for `thread_local` value can be made `const`
 --> futures-executor/src/enter.rs:4:49
  |
4 | std::thread_local!(static ENTERED: Cell<bool> = Cell::new(false));
  |                                                 ^^^^^^^^^^^^^^^^ help: replace with: `const { Cell::new(false) }`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local
  = note: `-D clippy::missing-const-for-thread-local` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::missing_const_for_thread_local)]`

EDIT: Filed #2914

@brodycj brodycj deleted the resolve-unnecessary-map-or-clippy-issue branch January 12, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants