Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robots: also disallow %5E (urlencoded caret) #2712

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Jan 8, 2025

Part of #1438
Followup to #2695

https://www.ietf.org/rfc/rfc1738.txt says:

Other characters are unsafe because
gateways and other transport agents are known to sometimes modify
such characters. These characters are "{", "}", "|", "", "^", "~",
"[", "]", and "`".

All unsafe characters must always be encoded within a URL.

https://datatracker.ietf.org/doc/html/rfc3986, which updates it, doesn't mention ^. 🤷🏻

@jsha jsha requested a review from a team as a code owner January 8, 2025 20:42
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jan 8, 2025
@syphar syphar merged commit 9368f26 into rust-lang:master Jan 9, 2025
11 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jan 9, 2025
@syphar
Copy link
Member

syphar commented Jan 9, 2025

@jsha code is deployed.

Just a thought in retrospect: since ~ is mentioned here too, should we also add the encoded variant for it?

@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jan 9, 2025
@jsha
Copy link
Contributor Author

jsha commented Jan 9, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants