Fix footer positionning

[GuillaumeGomez]

Fixes #1382.

Follow-up of #1367

[Nemo157]

Tested on new docs locally, fixes search page and footer not being at the bottom on short rustdoc pages. Can't easily test against old doc builds till it's deployed.

[GuillaumeGomez]

src/docbuilder/rustwide_builder.rs:730 is failing. Does someone knows why?

[syphar]

src/docbuilder/rustwide_builder.rs:730 is failing. Does someone knows why?

it seems like it is:

error: component 'rustfmt' for target 'x86_64-unknown-linux-gnu' is unavailable for download for channel nightly

So in any case unrelated to the style changes.

[GuillaumeGomez]

Good then, let's merge!

[jyn514]

@syphar could we separate "slow tests" and "fast tests" into different github checks? That would make it more clear that the unit tests are still passing.

I wonder if we could also change CI to try and install an older version of nightly if rustfmt isn't available. Or just disable rustfmt for the test image in the first place. rust-lang/rust#82385 is a better long term solution for this but in the meantime ...

[syphar]

@syphar could we separate "slow tests" and "fast tests" into different github checks? That would make it more clear that the unit tests are still passing.

definitely possible, I'll look into it.

I wonder if we could also change CI to try and install an older version of nightly if rustfmt isn't available. Or just disable rustfmt for the test image in the first place. rust-lang/rust#82385 is a better long term solution for this but in the meantime ...

I'll have to dig into where that is done, if I find it I'll update it :)

[jyn514]

I'll have to dig into where that is done, if I find it I'll update it :)

Hmm, it should already be working, it must have broken at some point:

docs.rs/src/docbuilder/rustwide_builder.rs

Lines 131 to 143 in e85bfdf

	self.toolchain.install(&self.workspace)?;
	for target in &targets_to_install {
	self.toolchain.add_target(&self.workspace, target)?;
	}
	// NOTE: rustup will automatically refuse to update the toolchain
	// if `rustfmt` is not available in the newer version
	// NOTE: this ignores the error so that you can still run a build without rustfmt.
	// This should only happen if you run a build for the first time when rustfmt isn't available.
	if let Err(err) = self.toolchain.add_component(&self.workspace, "rustfmt") {
	log::warn!("failed to install rustfmt: {}", err);
	log::info!("continuing anyway, since this must be the first build");
	}

[jyn514]

Yeah no that error is unrelated to why the build failed:

[2021-04-29T09:42:28Z WARN  docs_rs::docbuilder::rustwide_builder] failed to install rustfmt: unable to add component rustfmt for toolchain nightly via rustup
[2021-04-29T09:42:28Z INFO  docs_rs::docbuilder::rustwide_builder] continuing anyway, since this must be the first build

[syphar]

hm.. strange. In any case, the build cannot fail because of the styling (right?), so for this PR we're fine.

[jyn514]

Right, it also failed on #1384.