detect linker error due to bus error and categorize it as spurious #759
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/report/display.rs
Outdated
| @@ -16,6 +16,7 @@ impl ResultName for FailureReason { | |||
| FailureReason::OOM => "OOM".into(), | |||
| FailureReason::ICE => "ICE".into(), | |||
| FailureReason::NoSpace => "no space left on device".into(), | |||
| FailureReason::BusErrorWhileLinking => "bus error while linking".into(), | |||
There was a problem hiding this comment.
Can we instead categorize this failure as Failure::NoSpace? "bus error while linking" is not that helpful if you don't know what causes it.
There was a problem hiding this comment.
Ah, I was missing that causal relationship myself. In that case it makes sense to sort the bus error while linking under no space if it is the underlying fault. I will make the change when I am back in front of a computer.
There was a problem hiding this comment.
I have amended the PRs commit accordingly.
- sorted under NoSpace as thats the underlying reason for the bus error
fb87d45 to
31306ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should handle the linker errors as requested in #700 (comment)