-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to a current nightly #93
Conversation
@homunkulus r+ |
📌 Commit 4df5deb has been approved by |
💔 Test failed - status-travis |
@homunkulus try |
☀️ Test successful - status-appveyor, status-travis |
@mattico so, this is interesting. We are currently testing the arm-unknown-linux-gnueabi target with the nightly from 2016-09-21 and the all the tests pass. But in this PR, I tested the same arm target but vs today's nightly and it produces the failures you are seeing in #90 (see above, the first travis failure). Now, the .travis.yml has a comment that says that we are using the older nightly for arm because of rust-lang/rust#36518 which, iirc, is the problem with u32 -> f32 u32 -> f64 being UB because those are intrinsics implemented in compiler-rt. Now, that particular issue supposedly has already been already fixed (rust-lang/rust#36828) but perhaps the fix is not yet in today's nightly. |
@mattico Some things you could try to fix #90. Avoid doing a integer -> float (e.g. u32 -> f64) conversion. Maybe try directly generating random floating point values. Otherwise, you could try porting floatsidf and floatdidf to Rust so these tests end up using the Rust implementation rathern than compiler-rt's. |
No description provided.