Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable f16 for LoongArch #770

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Enable f16 for LoongArch #770

merged 2 commits into from
Mar 5, 2025

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Feb 26, 2025

r? @tgross35

Tracking issue for f16: rust-lang/rust#116909

@tgross35
Copy link
Contributor

Since loongarch doesn't have the system version to test against, could you add a line here so it uses the apfloat fallback

compiler-builtins/testcrate/build.rs

Line 59 in 453da66

|| target.arch == "powerpc64le"
?

@heiher
Copy link
Contributor Author

heiher commented Feb 26, 2025

Since loongarch doesn't have the system version to test against, could you add a line here so it uses the apfloat fallback

compiler-builtins/testcrate/build.rs

Line 59 in 453da66

|| target.arch == "powerpc64le"

?

Thanks for your suggestion.

@heiher heiher mentioned this pull request Feb 26, 2025
Merged
@heiher heiher force-pushed the enable-f16-loong branch from f438fb2 to 8f1dbb6 Compare March 3, 2025 05:43
@tgross35
Copy link
Contributor

tgross35 commented Mar 4, 2025

This should be good but I'm holding off since our compiler-builtins updates are a bit backed up.

@heiher heiher force-pushed the enable-f16-loong branch from 8f1dbb6 to 6da1daf Compare March 5, 2025 02:33
@tgross35
Copy link
Contributor

tgross35 commented Mar 5, 2025

I guess it is looking for those unmangled convert symbols to implement the other routines rather than only testing our __gnu_(h2f|f2h)_ieee. So you were right before, disabling the tests in testcrate/tests/conv.rs is probably the best thing to do until this makes it to a nightly rustc, then we can enable them again. Sorry about that.

@heiher
Copy link
Contributor Author

heiher commented Mar 5, 2025

I guess it is looking for those unmangled convert symbols to implement the other routines rather than only testing our __gnu_(h2f|f2h)_ieee. So you were right before, disabling the tests in testcrate/tests/conv.rs is probably the best thing to do until this makes it to a nightly rustc, then we can enable them again. Sorry about that.

Okay. I'll revert to the previous version, and I also sincerely appreciate your efforts in this.

@heiher heiher force-pushed the enable-f16-loong branch 2 times, most recently from bd5caab to 118bce2 Compare March 5, 2025 03:00
@tgross35
Copy link
Contributor

tgross35 commented Mar 5, 2025

Happy to help get the type working on more targets 👍 thanks for all the changes.

I have to hold off merging until rust-lang/rust#137634 goes through but LGTM.

heiher added 2 commits March 5, 2025 01:07
@heiher @tgross35
Enable f16 for LoongArch
657512b
@heiher @tgross35
Skip the f16-related tests on LoongArch
f7f3c19 
Skip the f16-related tests on LoongArch if there are no f16 symbols
in the system libraries.
@tgross35 tgross35 enabled auto-merge (rebase) March 5, 2025 06:07
@tgross35 tgross35 disabled auto-merge March 5, 2025 06:07
@tgross35 tgross35 enabled auto-merge (squash) March 5, 2025 06:08
@tgross35 tgross35 merged commit 4690673 into rust-lang:master Mar 5, 2025
26 checks passed
@github-actions github-actions bot mentioned this pull request Mar 5, 2025
Merged
@heiher heiher deleted the enable-f16-loong branch March 5, 2025 06:37
tgross35 added a commit to tgross35/rust that referenced this pull request Mar 5, 2025
@tgross35
Update compiler-builtins to 0.1.151
7923031 
This enables `f16` builtins for loongarch [1] and adds support for
Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774
@tgross35 tgross35 mentioned this pull request Mar 5, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2025
@bors
Auto merge of rust-lang#138038 - tgross35:update-builtins, r=<try>
2e5cd7c 
Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 5, 2025
@jieyouxu
Rollup merge of rust-lang#138038 - tgross35:update-builtins, r=tgross35
78d2633 
Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 5, 2025
@jieyouxu
Rollup merge of rust-lang#138038 - tgross35:update-builtins, r=tgross35
d2cdf5e 
Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Mar 6, 2025
@Noratrieb
Rollup merge of rust-lang#138038 - tgross35:update-builtins, r=tgross35
7ad72f4 
Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Mar 6, 2025
@compiler-errors
Rollup merge of rust-lang#138038 - tgross35:update-builtins, r=tgross35
071bc46 
Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
@rust-timer
Unrolled build for rust-lang#138038
4315046 
Rollup merge of rust-lang#138038 - tgross35:update-builtins, r=tgross35

Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
@bors
Auto merge of rust-lang#137674 - heiher:enable-f16-loong, r=<try>
66aec18 
Enable `f16` for LoongArch

Blocked on rust-lang/compiler-builtins#770

r? `@tgross35`

Tracking issue for f16: rust-lang#116909

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Mar 7, 2025
@compiler-errors
Rollup merge of #138038 - tgross35:update-builtins, r=tgross35
45b598f 
Update `compiler-builtins` to 0.1.151

This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2].

[1]: rust-lang/compiler-builtins#770
[2]: rust-lang/compiler-builtins#774

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 7, 2025
@jhpratt
Rollup merge of rust-lang#137674 - heiher:enable-f16-loong, r=tgross35
3893035 
Enable `f16` for LoongArch

Blocked on rust-lang/compiler-builtins#770

r? `@tgross35`

Tracking issue for f16: rust-lang#116909

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#137674 - heiher:enable-f16-loong, r=tgross35
3610020 
Enable `f16` for LoongArch

Blocked on rust-lang/compiler-builtins#770

r? ``@tgross35``

Tracking issue for f16: rust-lang#116909

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#137674 - heiher:enable-f16-loong, r=tgross35
6e7d135 
Enable `f16` for LoongArch

Blocked on rust-lang/compiler-builtins#770

r? ```@tgross35```

Tracking issue for f16: rust-lang#116909

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
@rust-timer
Unrolled build for rust-lang#137674
1a4bd2a 
Rollup merge of rust-lang#137674 - heiher:enable-f16-loong, r=tgross35

Enable `f16` for LoongArch

Blocked on rust-lang/compiler-builtins#770

r? ```@tgross35```

Tracking issue for f16: rust-lang#116909

try-job: dist-loongarch64-linux
try-job: dist-loongarch64-musl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heiher @tgross35