Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macos-latest in CI for aarch64-apple-darwin #676

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

beetrees
Copy link
Contributor

@beetrees beetrees commented Aug 24, 2024

Per the GitHub actions docs, macos-latest now refers to the M1-CPU-using macos-14. This PR changes the aarch64-apple-darwin CI to match the other CI targets, which all use the -latest OS versions.

@tgross35
Copy link
Contributor

Oh that is going to be an interesting change. Could you also change the x86 image to be macos-13?

I am pretty surprised they didn't distinguish these further than whatever the latest happens to be.

@tgross35
Copy link
Contributor

Thanks for catching this, this sort of change probably has to happen at a ton of our repos.

@tgross35 tgross35 enabled auto-merge August 24, 2024 10:54
@tgross35 tgross35 merged commit d78cc8e into rust-lang:master Aug 24, 2024
24 checks passed
@beetrees beetrees deleted the ci-macos-latest branch August 24, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants