Add support for uwp targets #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm gonna try to centralize conversation on rust-lang/rust#60260, so I'll comment there soon. |
|
Updated the PR with the new triplet |
|
Ok the naming is final enough now that I'm gonna go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This MR is related to rust-lang/rust#60260, and allows the use of "uwp" as part of the target.
I'm unsure what the best way is, when it comes to cross dependent MRs, so I'll gladly change things according to your reviews!
As noted in the rust-lang MR, the i686 target isn't fully functional, due to a mismatch in the stack unwinding model (LLVM's libunwind assumes SjLj when targeting i686, rust-lang assumes SEH will be available)
Thanks,