Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: ensure clang --driver-mode=cl is MSVC- and clang-cl-like #1381

Merged
merged 3 commits into from
Feb 4, 2025
Merged

test: ensure clang --driver-mode=cl is MSVC- and clang-cl-like #1381

merged 3 commits into from
Feb 4, 2025

Conversation

ErichDonGubler
Copy link
Contributor

@ErichDonGubler ErichDonGubler commented Jan 31, 2025 •
edited
Loading

No description provided.

@ErichDonGubler ErichDonGubler force-pushed the clang-driver_mode_cl-testing branch 3 times, most recently from b3a95bc to 502bc1f Compare February 3, 2025 22:20
madsmtm
madsmtm reviewed Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it so far!

@ErichDonGubler ErichDonGubler force-pushed the clang-driver_mode_cl-testing branch 2 times, most recently from 38843c7 to 6139264 Compare February 4, 2025 01:39
@ErichDonGubler ErichDonGubler marked this pull request as ready for review February 4, 2025 01:46
@ErichDonGubler
Copy link
Contributor Author

Just confirmed that this test fails prior to #1378, so I'm satisfied with where it's at.

@ErichDonGubler ErichDonGubler force-pushed the clang-driver_mode_cl-testing branch from 6139264 to 8139264 Compare February 4, 2025 01:50
NobodyXu
NobodyXu approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@NobodyXu NobodyXu merged commit a49184e into rust-lang:main Feb 4, 2025
52 checks passed
@ErichDonGubler ErichDonGubler deleted the clang-driver_mode_cl-testing branch February 5, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm madsmtm left review comments

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErichDonGubler @madsmtm @NobodyXu