Skip to content

Commit

Permalink
Revert "For non-MSVC, separate flags/options from the input file. (#513
Browse files Browse the repository at this point in the history
…)"
  • Loading branch information
ChrisDenton authored Nov 8, 2022
1 parent 1c8b4a0 commit 65a5497
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 23 deletions.
7 changes: 0 additions & 7 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1345,13 +1345,6 @@ impl Build {
if self.cuda && self.files.len() > 1 {
cmd.arg("--device-c");
}
if compiler.family == (ToolFamily::Msvc { clang_cl: true }) {
// #513: For `clang-cl`, separate flags/options from the input file.
// When cross-compiling macOS -> Windows, this avoids interpreting
// common `/Users/...` paths as the `/U` flag and triggering
// `-Wslash-u-filename` warning.
cmd.arg("--");
}
cmd.arg(&obj.src);
if cfg!(target_os = "macos") {
self.fix_env_for_apple_os(&mut cmd)?;
Expand Down
16 changes: 0 additions & 16 deletions tests/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -343,14 +343,6 @@ fn gnu_static() {
test.cmd(0).must_have("-static").must_not_have("-shared");
}

#[test]
fn gnu_no_dash_dash() {
let test = Test::gnu();
test.gcc().file("foo.c").compile("foo");

test.cmd(0).must_not_have("--");
}

#[test]
fn msvc_smoke() {
reset_env();
Expand Down Expand Up @@ -419,11 +411,3 @@ fn msvc_no_static_crt() {

test.cmd(0).must_have("-MD");
}

#[test]
fn msvc_no_dash_dash() {
let test = Test::msvc();
test.gcc().file("foo.c").compile("foo");

test.cmd(0).must_not_have("--");
}

0 comments on commit 65a5497

Please sign in to comment.