Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unused_unsafe in LazyCell in preparation for lib change #4972

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

varkor
Copy link
Member

@varkor varkor commented Jan 24, 2018

rust-lang/rust#47204 makes UnsafeCell::into_inner safe, which means LazyCell::into_inner will no longer need an unsafe block. LazyCell is a blocker for the change in Rust: this fix should allow the change to take place.

rust-lang/rust#47204 makes `UnsafeCell::into_inner` safe, which means `LazyCell::into_inner` will no longer need an `unsafe` block. `LazyCell` is a blocker for the change in Rust: this fix should allow the change to take place.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Jan 24, 2018

📌 Commit 5d22cce has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jan 24, 2018

⌛ Testing commit 5d22cce with merge b1c3e78...

bors added a commit that referenced this pull request Jan 24, 2018
Allow unused_unsafe in LazyCell in preparation for lib change

rust-lang/rust#47204 makes `UnsafeCell::into_inner` safe, which means `LazyCell::into_inner` will no longer need an `unsafe` block. `LazyCell` is a blocker for the change in Rust: this fix should allow the change to take place.
@bors
Copy link
Contributor

bors commented Jan 24, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing b1c3e78 to master...

@bors bors merged commit 5d22cce into rust-lang:master Jan 24, 2018
@varkor varkor deleted the lazy-cell-unused-unsafe branch January 24, 2018 18:28
@ehuss ehuss added this to the 1.25.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants