Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update language regarding repository vs package root #4375

Merged
merged 2 commits into from
Aug 8, 2017

Conversation

behnam
Copy link
Contributor

@behnam behnam commented Aug 7, 2017

In the current documentation, there are many places with language that
assumes a repository (as in VCS) is the same as package root (the
directory where Cargo.toml sits).

With the new workspace features, this is far from true now, and the
inaccurate language makes it difficault for newbies or developers
without much familiarity with the cargo internals with authoring their
manifest files.

This diff tries to use the right terms for places any of these concepts
is referred to:

  • Package root,
  • Workspace root,
  • VCS repository, and
  • Package repository/index, like crates.io.

Fixes #4367

In the current documentation, there are many places with language that
assumes a *repository* (as in VCS) is the same as *package root* (the
directory where `Cargo.toml` sits).

With the new workspace features, this is far from true now, and the
inaccurate language makes it difficault for newbies or developers
without much familiarity with the cargo internals with authoring their
manifest files.

This diff tries to use the right terms for places any of these concepts
is referred to:

* Package root,
* Workspace root,
* VCS repository, and
* Package repository/index, like crates.io.
@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@behnam
Copy link
Contributor Author

behnam commented Aug 7, 2017

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned matklad Aug 7, 2017
@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Aug 7, 2017

📌 Commit e774367 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Aug 7, 2017

⌛ Testing commit e774367 with merge 35bda50...

bors added a commit that referenced this pull request Aug 7, 2017
[docs] Update language regarding repository vs package root

In the current documentation, there are many places with language that
assumes a *repository* (as in VCS) is the same as *package root* (the
directory where `Cargo.toml` sits).

With the new workspace features, this is far from true now, and the
inaccurate language makes it difficault for newbies or developers
without much familiarity with the cargo internals with authoring their
manifest files.

This diff tries to use the right terms for places any of these concepts
is referred to:

* Package root,
* Workspace root,
* VCS repository, and
* Package repository/index, like crates.io.

Fixes <#4367>
@bors
Copy link
Contributor

bors commented Aug 8, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 35bda50 to master...

@bors bors merged commit e774367 into rust-lang:master Aug 8, 2017
@behnam behnam deleted the root-vs-repo branch August 8, 2017 01:56
@ehuss ehuss added this to the 1.21.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs language regarding repository vs package root
6 participants