Ignore a test that accesses crates.io for now #4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests in general shouldn't hit the network, but this one requires a crate from crates.io :(
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 3b4e89f has been approved by |
bors
added a commit
that referenced
this pull request
Jun 25, 2017
Ignore a test that accesses crates.io for now Tests in general shouldn't hit the network, but this one requires a crate from crates.io :(
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jun 26, 2017
Update Cargo Haven't run extensive tests locally (not really sure what to test) but this primarily pulls in minor changes: rust-lang/cargo#4215, rust-lang/cargo#4209, and rust-lang/cargo#4218. The last one fixes the flaky cargo test by ignoring it, which should unblock #42745 -- that's beta nominated. r? @alexcrichton
bors
added a commit
that referenced
this pull request
Apr 15, 2019
…ichton Fix test include_overrides_gitignore. This test was added in #4180 and was disabled in #4218. I don't think it is really feasible to get filetime into the test. The test was also using some questionable behavior of modifying contents of `src` from a `build.rs` script. I rewrote the test to directly test the original change of having `package.include` override `.gitignore`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in general shouldn't hit the network, but this one requires a crate from
crates.io :(