Create matrix for #3186 #3190
Closed
Create matrix for #3186 #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because Travis is insufficiently clever about inferring matrices from scattered directives, and our needs are highly specific. This is for rust-lang#3186
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Don't merge yet, I need to trick the cross builders into not running tests |
|
Continuing in #3239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://travis-ci.org/edunham/cargo/builds/166869098, which is a messier history to the same set of changes, demonstrates that the matrix is constructed correctly to run a bunch of builds we didn't previously.
That build set's failures will reveal what if any fixups we need to pass these tests on Travis as we do on Buildbot, and after those land, this will be ready to merge. Or maybe we'll luck out and this will be green... but that seems unlikely.