Simplify ProcessBuilder to be closer to Command #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes many bounds to ToCStr to stay in line with the since-introduced Command structure. The builder remains separate of command to have control over executing and Show. Path-related methods have been removed and env-initialization/management are left to Command, ProcessBuilder only keeps track of the delta.
Unfortunately this cannot yet have a test for it as rustc itself does not work if it is run on non-utf8 paths.
| base.args(plugin_args.as_slice())], | ||
| Target => vec![target], | ||
| Plugin => vec![plugin], | ||
| PluginAndTarget if cx.config.target().is_none() => vec![target], |
There was a problem hiding this comment.
Is really meant to be target().is_none() => target? It seems to me that target being none would imply that this should be vec![plugin]?
There was a problem hiding this comment.
If cx.config.target() is none then the target/plugin commands end up being the same thing, so one can be discarded (no need to compile twice).
Merged
bors
added a commit
that referenced
this pull request
Jul 22, 2014
At the same time, remove a bunch of `path.display().to_string()` and friends.
bors
added a commit
to alexcrichton/cargo
that referenced
this pull request
Sep 2, 2014
At the same time, remove a bunch of `path.display().to_string()` and friends.
bors
added a commit
to alexcrichton/cargo
that referenced
this pull request
Sep 2, 2014
This command is used to create a new cargo repository at a destination that previously does not exist. A separate command, cargo-init, will be implemented to initialize an already-existing repository. cc rust-lang#21 This is currently rebased on rust-lang#238
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the same time, remove a bunch of
path.display().to_string()and friends.