Tweak the new project template to be more idiomatic. #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wycats (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
👍 |
bors
added a commit
that referenced
this pull request
Jan 11, 2016
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Merged
vi
added a commit
to vi/cargo
that referenced
this pull request
Jan 23, 2016
When non-existing directory is provided as argument, it
works just like "cargo new".
When existing directory is used, it may also create template
source file like "cargo new" or may find and use existing
source code for Cargo.toml.
Squashed commit of the following:
cargo init: Supply USER envvar for one test
cargo init: Other message when Cargo.toml already exists
cargo init: Resolve conflict after with rust-lang#2257
fix minor issues
cargo new/init: Simplify error handling code in entry points
cargo new/init: Better message for invalid characters in name
cargo init: fix minor issues in test
cargo init: Avoid excessive builds in the test
cargo init: minor fixes
cargo init: Skip no_filename test on Windows
cargo init: Implement better error message for bin name clash
cargo init: minor fixes
cargo init: handle "/" path
cargo init: Actualise
cargo new: Fix upper case error message in test
cargo init: Remove paths::{file,directory}_already_exists
fix uppper-case error messages
cargo init: Fix minor issues per diff comments
cargo init: Change binary handling
cargo init: Move multiple lib error detection away from mk
cargo init: Support optional path argument
cargo init: Fix minor issues per Github comments
cargo init: Fix complaint from tests/check-style.sh
cargo init: Handle projects with multiple mains
cargo init: Major refactor, multi-target projects
cargo init: Add Cargo.lock unconditionally
cargo init: Fix complains from tests/check-style.sh
cargo init: Tests for handling VCS
cargo init: Handle VCS
cargo init: work in progress
cargo init: Deduplicate some things between new and init
cargo init: Auto-detection of --bin
cargo init: work in progress...
cargo init: Fix tests and allow explicit --vcs
cargo init: intermediate refactor
cargo init: First sketch of implementation
cargo init: Preliminary test
cargo init: first stub
See
https://github.com/vi/cargo/tree/cargo_init_unsquashed
for individual commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.