chore: dont check cargo-util semver until 1.86 is released #15222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weihanglo
commented
Feb 22, 2025
f19b8cb to
37352a8
Compare
This fixes the current confusing failures in our CI pipeline: * https://github.com/rust-lang/cargo/actions/runs/13465687015/job/37630870984 * https://github.com/rust-lang/cargo/actions/runs/13469881475/job/37642079118 CI job failed because of this major SemVer breakage: ```diff -pub fn strip_prefix_canonical<P: AsRef<Path>>( - path: P, - base: P, +pub fn strip_prefix_canonical( + path: impl AsRef<Path>, + base: impl AsRef<Path>, ) -> Result<PathBuf, std::path::StripPrefixError> { ``` While cargo-util does have that change violating SemVer, it is unlikely people use it with turbo-fish syntax. And cargo-util is essentially for internal use. See: * https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/check-version-bump.20failure * https://forge.rust-lang.org/policies/crate-ownership.html#internal-use
37352a8 to
80331b1
Compare
ehuss
approved these changes
Feb 23, 2025
15 tasks
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 28, 2025
Update cargo 11 commits in 1d1d646c06a84c1aa53967b394b7f1218f85db82..2622e844bc1e2e6123e54e94e4706f7b6195ce3d 2025-02-21 21:38:53 +0000 to 2025-02-28 12:33:57 +0000 - Bump `cc` to 1.2.16 to fix `x86` windows jobs in rust-lang/rust CI (rust-lang/cargo#15245) - refactor(tree): Abstract the concept of a NodeId (rust-lang/cargo#15237) - feat: implement RFC 3553 to add SBOM support (rust-lang/cargo#13709) - refactor(tree): Abstract the concept of an edge (rust-lang/cargo#15233) - chore: bump openssl to v3 (rust-lang/cargo#15232) - fix(package): Register workspace member renames in overlay (rust-lang/cargo#15228) - Implemented `build.build-dir` config option (rust-lang/cargo#15104) - feat: add completions for `--manifest-path` (rust-lang/cargo#15225) - chore: semver-check build-rs against beta channel (rust-lang/cargo#15223) - chore: depend on openssl-sys to correctly pin its version (rust-lang/cargo#15224) - chore: dont check cargo-util semver until 1.86 is released (rust-lang/cargo#15222)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve
This fixes the current confusing failures in our CI pipeline:
CI job failed because of this major SemVer breakage:
While cargo-util does have that change violating SemVer,
it is unlikely people use it with turbo-fish syntax.
And cargo-util is essentially for internal use.
See:
How should we test and review this PR?
CI passes and we're all good, though we are violating SemVer policy 😬.