Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a file whitelist when creating a package (vs. blacklist) #880

Closed
carllerche opened this issue Nov 15, 2014 · 1 comment
Closed

Use a file whitelist when creating a package (vs. blacklist) #880

carllerche opened this issue Nov 15, 2014 · 1 comment

Comments

@carllerche
Copy link
Member

Personally, I will always have junk in my repo that I will forget to delete before packaging. I would prefer a whitelist strategy over blacklist. It could default to using the result of git ls-files (or the default cargo structure if git is not used).

As a somewhat supporting factor, I almost pushed out my target directory as part of the build. My .gitignore directory has /target/ and I was in a nested package.
@alexcrichton alexcrichton mentioned this issue Jan 6, 2015
Merged
alexcrichton added a commit to alexcrichton/cargo that referenced this issue Jan 8, 2015
@alexcrichton
Update how a PathSource is traversed for git repos
5935ec1 
This fixes a number of bugs along the way:

* Submodules are now recursed into explicitly for packaging, fixing rust-lang#943
* A whitelist has been implemented, fixing rust-lang#880
* Git repos are now always used if there is a package that resides at the root,
  not just if the current package resides at the root.
bors added a commit that referenced this issue Jan 8, 2015
@bors
Auto merge of #1131 - alexcrichton:issue-880, r=brson
8c01b6b 
This fixes a number of bugs along the way:

* Submodules are now recursed into explicitly for packaging, fixing #943
* A whitelist has been implemented, fixing #880
* Git repos are now always used if there is a package that resides at the root,
  not just if the current package resides at the root.
@alexcrichton
Copy link
Member

Added in #1131

@huonw huonw mentioned this issue Jan 14, 2015
Closed
lucab pushed a commit to lucab/cargo that referenced this issue Jan 25, 2015
@alexcrichton
Update how a PathSource is traversed for git repos
70b1607 
This fixes a number of bugs along the way:

* Submodules are now recursed into explicitly for packaging, fixing rust-lang#943
* A whitelist has been implemented, fixing rust-lang#880
* Git repos are now always used if there is a package that resides at the root,
  not just if the current package resides at the root.
@felixc felixc mentioned this issue Dec 24, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carllerche @alexcrichton