Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo verify-project returns incorrect results when using unstable features #6209

Closed
pietroalbini opened this issue Oct 23, 2018 · 0 comments · Fixed by #6326
Closed

cargo verify-project returns incorrect results when using unstable features #6209

pietroalbini opened this issue Oct 23, 2018 · 0 comments · Fixed by #6326
Assignees

Comments

@pietroalbini
Copy link
Member

cargo verify-project returns a positive response if a crate is using unstable features on the stable toolchain, even if every other cargo command returns an error.

$ cargo read-manifest
error: failed to parse manifest at `/.../Cargo.toml`

Caused by:
  the cargo feature `test-dummy-unstable` requires a nightly version of Cargo, but this is the `stable` channel

$ cargo verify-project
{"success":"true"}
Sample Cargo.toml
cargo-features = ["test-dummy-unstable"]

[package]
name = "foo"
version = "0.1.0"
authors = ["Pietro Albini <pietro@pietroalbini.org>"]

[dependencies]
@dwijnand dwijnand self-assigned this Nov 17, 2018
bors added a commit that referenced this issue Nov 19, 2018
…es, r=alexcrichton

Make verify-project honour unstable features

Fixes #6209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants