Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous use statement #4193

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

Grimmscorpp
Copy link
Contributor

In Listing 14-7 of Chapter 14, the use add_one; statement is redundant and can be removed. Before the Rust 2018 edition, this statement was required to bring the add_one crate into scope, so it likely got missed during refactorings from that transition.

By removing this line, the code becomes more concise and reflects the current best practices for using external crates in Rust.

Issue #4186

In Listing 14-7 of Chapter 14, the `use add_one;` statement is redundant
and can be removed. Before the Rust 2018 edition, this statement was
required to bring the `add_one` crate into scope, so it likely got
missed during refactorings from that transition.

By removing this line, the code becomes more concise and reflects the
current best practices for using external crates in Rust.

Issue #4186
@Grimmscorpp Grimmscorpp changed the title Remove extraneous use statement (#4193) Remove extraneous use statement Jan 7, 2025
Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I’m going to revert the unrelated changes to _ from * in other files, then merge!

src/ch06-03-if-let.md Outdated Show resolved Hide resolved
src/ch21-03-graceful-shutdown-and-cleanup.md Outdated Show resolved Hide resolved
src/ch21-03-graceful-shutdown-and-cleanup.md Outdated Show resolved Hide resolved
@chriskrycho chriskrycho merged commit fc64519 into rust-lang:main Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants