Convert Listings in Chapter 06 to <Listing>
#3977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My bad, when I copy and pasted the captions from the `<span>` into the `<Listing>`, I failed to realize that my text editor copied over the line numbers into the strings. Removed them, should be all good now.
…cter limit (READ DESC.) I'm unsure whether wrapping the text may cause the listing text to be wrapped too as the newlines are found within quotation marks. If it causes issues, feel free to revert this commit. Another odd thing is that my editor uncolored the closing `</Listing>` tag when I split the lines. Maybe the newline characters need to be escaped with a backslash?
|
Thanks! Looks like you have at least one unclosed |
|
Ah, I see your last commit – that one is the problem, I expect. HTML blocks (like these, but also just like the old |
21 tasks
…80 character limit (READ DESC.)" This reverts commit b1bb69f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, here is chapter 06 adapted to the new
<Listing>pre-processor. I'm not sure if everything works as intended since I couldn't getmdbookto behave properly on my machine, so please check the sanity of my changes.I also changed numberless listings (as in, they have a file name, but no number), so feel free to revert those commits if they are not yet fully functional by the time they will be merged.
Please also check all the comments I have left in commit descriptions and the issue thread for further concerns I might have about the code.
(By the way, I also fixed some conflicts while moving the commits around)
Issue #3919