Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a basic version of
minmax_by
(similar tosort_by
).Note that it is (at least, currently) implemented to take an
Fn
(instead of anFnMut
) as a comparison function. Do you think aFnMut
comparison function would offer sensible advantages?Just in case this matters: I also suggested to add
max_by
andmin_by
to the stdlib, sominmax_by
would be in line with that (rust-lang/rust#35856).