Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Document MSRV on README #29

Merged
merged 1 commit into from
May 5, 2020
Merged

Document MSRV on README #29

merged 1 commit into from
May 5, 2020

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Apr 21, 2020

@eldruin eldruin requested a review from a team as a code owner April 21, 2020 20:01
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m T-tools labels Apr 21, 2020
@adamgreig adamgreig mentioned this pull request Apr 25, 2020
Closed
32 tasks
@adamgreig
Copy link
Member

It looks like the CI is failing due to our backtrace dependency failing to build on 1.31; could you try bumping to a higher MSRV?

@eldruin
Copy link
Member Author

eldruin commented May 5, 2020

Sure. Sorry I did not notice before.
I set MSRV to 1.32.0 which is the one from backtrace and that worked.

adamgreig
adamgreig approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented May 5, 2020

Build succeeded:

@bors bors bot merged commit 9298d12 into rust-embedded:master May 5, 2020
@eldruin eldruin deleted the document-msrv branch May 6, 2020 06:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees

@adamgreig adamgreig

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eldruin @rust-highfive @adamgreig