Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSRV 1.34.0 #32

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Add MSRV 1.34.0 #32

merged 1 commit into from
Apr 27, 2020

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Apr 22, 2020

@otavio
Copy link

otavio commented Apr 22, 2020

Due to use of Kleene operator for "at most one" operator, the MSRV needs to be raised to 1.32 it seems.

@otavio
Copy link

otavio commented Apr 22, 2020

The error comes from anyhow from the dev-dependencies. So maybe it could be reworked?

@therealprof
Copy link

Raising the MSRV to 1.32 sounds fine to me.

@eldruin eldruin changed the title Add MSRV 1.31.0 Add MSRV 1.34.0 Apr 23, 2020
@eldruin
Copy link
Member Author

eldruin commented Apr 23, 2020

Rust 1.32.0 was not enough. As per anyhow 1.0.28 documentation, Rust 1.34+ is necessary. However, it is not explicitly stated there that 1.34.0 is the MSRV.
With 1.34.0 this crate builds fine.

@adamgreig adamgreig mentioned this pull request Apr 25, 2020
Closed
32 tasks
@nastevens
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 27, 2020

👎 Rejected by too few approved reviews

@nastevens
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 27, 2020

Build succeeded:

@bors bors bot merged commit 944a086 into rust-embedded:master Apr 27, 2020
@eldruin eldruin deleted the add-msrv branch April 28, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastevens nastevens nastevens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eldruin @otavio @therealprof @nastevens