Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust on Espressif discovery journey #559

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

SergioGasquez
Copy link
Contributor

Hi! Since we at Espressif have something similar to the discovery books, but in a different format, I thought that it might be worth mentioning the resources in the discovery book.

If you want to keep this for the current content only, feel free to close the PR. Also, not sure if the format in which I added it, is the best, so also open to any suggestions!

@SergioGasquez SergioGasquez requested a review from a team as a code owner February 19, 2024 08:46
@hdoordt
Copy link
Member

hdoordt commented May 13, 2024

This feels a bit out of place to me. I think a reference like this is more fit for an entry in Awesome Embedded Rust. Which, as it turns out, it already is

@sirhcel
Copy link
Contributor

sirhcel commented May 13, 2024

Wow, this got closed pretty fast. I would still advocate for including a reference in the Discovery Book for the following reasons:

  • At RustNL we discussed to cover sync and asnyc embedded Rust in the discovery book, so at least referring to the "second dimension" of of embedded Rust - no_std and std - feels natural to me
  • Especially the RISC-V devices offer a comfortable way of getting into embedded Rust and they are well supported and easily accessible targets
  • Awesome Embedded Rust is really broad and overwhelming for "young players" and I from my perspective these two points (std + sync, std + async) in the design space could and should be mentioned in the Discovery Book as well
  • Training resources are already available

Documentation and the Discovery Book is currently under discussion. What about discussing the if, how and where there as well?

@SergioGasquez SergioGasquez reopened this May 14, 2024
@SergioGasquez
Copy link
Contributor Author

I guess Ill reopen it for others to jump in an give an opinion

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this is slightly out of place because the relationship is not clear. We also do not link to the rust embedded book here (but maybe we should!). Otherwise this seems fine to me.
I think adding an "Alternatively" or similar word might be an improvement.

@SergioGasquez
Copy link
Contributor Author

I think adding an "Alternatively" or similar word might be an improvement.

I'm happy to use another wording, what about "Alternative Discovery Books"?

@SergioGasquez
Copy link
Contributor Author

Any input here? @eldruin @sirhcel happy to make any changes if required

@BartMassey
Copy link
Member

Please give us a bit more time to transition to the newer discovery-mb2 book; we're still sorting out exactly how we want to handle other "Discoveries".

@SergioGasquez
Copy link
Contributor Author

Please give us a bit more time to transition to the newer discovery-mb2 book; we're still sorting out exactly how we want to handle other "Discoveries".

Hi! Any updates on this?? Im happy to rebase my changes if needed

@BartMassey
Copy link
Member

Yes, we really need to deal with this. Sincere apologies for the delay. If you rebase your changes I'll go ahead and merge them here, and also migrate them to the newer repo.

@SergioGasquez
Copy link
Contributor Author

Yes, we really need to deal with this. Sincere apologies for the delay. If you rebase your changes I'll go ahead and merge them here, and also migrate them to the newer repo.

No worries, just rebased my PR. Let me know if you want me to help migrating them, although Im not sure which is the newer repo

Copy link
Member

@BartMassey BartMassey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks much for this.

@BartMassey BartMassey added this pull request to the merge queue Feb 5, 2025
@BartMassey
Copy link
Member

Thank you very much for this. I plan to try it all out myself sometime soon.

Merged via the queue into rust-embedded:master with commit 04e3e9c Feb 5, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants