Add MSRV note to README #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @therealprof (rust_highfive has picked a reviewer for you, use r? to override) |
32 tasks
bors bot
added a commit
that referenced
this pull request
Apr 21, 2020
207: Add MSRV note to README r=korken89 a=adamgreig Ref. rust-embedded/wg#445 Co-authored-by: Adam Greig <adam@adamgreig.com>
|
Build failed: |
|
We've hit #204 and all nightly builds are now failing due to |
|
I've updated the PR to also allow failures on nightly builds. |
|
bors retry |
|
👎 Rejected by too few approved reviews |
|
@korken89 I've rebased the PR, could you re-review please? |
therealprof
approved these changes
May 12, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 12, 2020
207: Add MSRV note to README r=therealprof a=adamgreig Ref. rust-embedded/wg#445 Co-authored-by: Adam Greig <adam@adamgreig.com>
|
Timed out. |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
May 12, 2020
207: Add MSRV note to README r=therealprof a=adamgreig Ref. rust-embedded/wg#445 Co-authored-by: Adam Greig <adam@adamgreig.com>
|
bors retry |
1 similar comment
|
bors retry |
|
Build succeeded: |
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
207: Rejig link.x to include more lables to help the linker lay out the ob… r=thejpster a=therealprof …jects Tested with 1.34.0 and 1.38.0 and careful inspection of the linker map generated on the previously failing https://github.com/rust-lang/rust/files/3722440/minimal-rust-lld-issue.zip Closes #188 (I believe) Closes rust-lang/rust#65391 Signed-off-by: Daniel Egger <daniel@eggers-club.de> Co-authored-by: Daniel Egger <daniel@eggers-club.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. rust-embedded/wg#445