Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Add MSRV 1.33.0 to CI #53

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Add MSRV 1.33.0 to CI #53

merged 1 commit into from
Apr 23, 2020

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Apr 21, 2020

@eldruin eldruin requested a review from a team as a code owner April 21, 2020 19:39
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@therealprof
Copy link
Contributor

1.32 doesn't seem to do it for armv8

@therealprof
Copy link
Contributor

cf. https://travis-ci.org/github/rust-embedded/cortex-m-semihosting/jobs/677848641

@eldruin eldruin changed the title Add MSRV 1.32.0 to CI Add MSRV 1.33.0 to CI Apr 23, 2020
@eldruin
Copy link
Member Author

eldruin commented Apr 23, 2020

Ok. Support for armv8 was added in Rust 1.33.0.
Now the nightly build broke due to the combination of using deprecated macro asm! and having #[deny(warnings)] but this can be solved in a separate PR.

@therealprof
Copy link
Contributor

Yes, not worried about nightly at this point.

therealprof
therealprof approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@therealprof
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 23, 2020

Build succeeded:

@bors bors bot merged commit 05766e3 into rust-embedded:master Apr 23, 2020
@eldruin eldruin deleted the add-msrv branch April 23, 2020 12:45
@adamgreig adamgreig mentioned this pull request Apr 25, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@adamgreig adamgreig

Labels
S-waiting-on-review T-cortex-m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eldruin @rust-highfive @therealprof @adamgreig