Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional command to try when verifying installation. #259

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

aphistic
Copy link
Contributor

The given commands didn't work for me, so I looked through my system for a similarly-named file and found interface/stlink-v2-1.cfg. When I tried that I ended up getting the breakpoints result mentioned.

One thing I'm still a little confused about is the mention of having an older revision of the board. I don't think I have an old version because I bought it recently and my PCB says "MB1035D" next to the STM32 chip. It might be due to having a newer distribution of OpenOCD because it doesn't have any files named stlink.cfg, only stlink-v1.cfg, stlink-v2.cfg, and stlink-v2-1.cfg. I didn't want to make any changes to the rest of the description, though, because it doesn't change the fact it's something that you need to keep in mind later (I assume, I'm just starting the book), and I don't feel I understand enough at this point to make that decision.

@aphistic aphistic requested a review from a team as a code owner August 17, 2020 00:51
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Aug 17, 2020
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 17, 2020

Build succeeded:

@bors bors bot merged commit 95effbf into rust-embedded:master Aug 17, 2020
@adamgreig
Copy link
Member

@aphistic, how did you install your openocd version and are you sure it's recent? The new stlink.cfg file has been around for a while and is in the current openocd source, but their releases are extremely infrequent and so if you're missing the file it might just be that your openocd is old.

@aphistic
Copy link
Contributor Author

aphistic commented Aug 17, 2020

@aphistic, how did you install your openocd version and are you sure it's recent? The new stlink.cfg file has been around for a while and is in the current openocd source, but their releases are extremely infrequent and so if you're missing the file it might just be that your openocd is old.

Hey! I installed the openocd package that comes with Ubuntu 20.04. It also seem to be missing anything relating to ST-LINK v3 or the st-link interface driver that it seems like the openocd documentation pdf mentions. Here's the package I installed: https://packages.ubuntu.com/focal/amd64/openocd/filelist

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 20, 2020
Update books

## nomicon

2 commits in bfe1ab96d717d1dda50e499b360f2e2f57e1750a..25854752549d44d76fbd7650e17cb4f167a0b8fb
2020-06-05 13:19:42 -0400 to 2020-08-19 16:41:48 -0400
- Follow-up of rust-lang#75152 (rust-lang/nomicon#235)
- Follow-up for rust-lang#74850 (rust-lang/nomicon#233)

## reference

7 commits in c9b2736a059469043177e1e4ed41a55d7c63ac28..1b6c4b0afab97c0230433466c97167bbbe8445f6
2020-08-03 03:34:03 -0700 to 2020-08-18 17:04:28 -0700
- Some constant/static updates. (rust-lang/reference#867)
- Add casting rules from function items to other types (rust-lang/reference#878)
- Apply joshtriplett's suggestion
- Add note clarifying 16-bit support.
- Document min pointer width.
- Update to `dyn Trait` syntax in a couple places (rust-lang/reference#875)
- mention that `#[track_caller]` on `fn main` is forbidden (rust-lang/reference#872)

## book

2 commits in 363293c1c5ce9e84ea3935a5e29ce8624801208a..c0a6a61b8205da14ac955425f74258ffd8ee065d
2020-08-03 15:56:30 -0500 to 2020-08-14 14:21:49 -0500
- Correct listing 11-10: Take tests module out of main function. (rust-lang/book#2427)
- Update link to russian translation (rust-lang/book#2423)

## rust-by-example

5 commits in 2e9271981adc32613365810f3428334c07095215..80a10e22140e28392b99d24ed02f4c6d8cb770a0
2020-07-27 13:39:16 -0500 to 2020-08-08 09:56:46 -0300
- Add tuple `..` operator example (rust-lang/rust-by-example#1368)
- Clarify wording (rust-lang/rust-by-example#1366)
- Include arc (rust-lang/rust-by-example#1365)
- Modify supertraits sample code (rust-lang/rust-by-example#1361)
- Remove mention of `try!` in `Display` example (rust-lang/rust-by-example#1357)

## embedded-book

3 commits in b5256448a2a4c1bec68b93c0847066f92f2ff5a9..0cd2ca116274b915924c3a7e07c1e046b6f19b77
2020-07-24 23:09:29 +0000 to 2020-08-19 10:33:15 +0000
- Ignore unused argument in closure  (rust-embedded/book#261)
- Fix broken sentence  (rust-embedded/book#260)
- Add additional command to try when verifying installation.  (rust-embedded/book#259)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants