Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn when migration file name is malformed #130

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Sep 24, 2020

This is my take on warnings for malformed migration names. I wanted to include file name in the warning message as well, hence the condition in Some branch.

Closes: #129

@lgestc lgestc force-pushed the ft-warn-about-malformed-migration-names branch from 274fafc to 10b9b05 Compare September 24, 2020 07:45
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Only a minor issue addressed

refinery_core/src/util.rs Outdated Show resolved Hide resolved
@lgestc lgestc force-pushed the ft-warn-about-malformed-migration-names branch from 10b9b05 to e1f5aaa Compare September 25, 2020 06:51
@lgestc lgestc requested a review from jxs September 25, 2020 06:52
@lgestc
Copy link
Contributor Author

lgestc commented Sep 25, 2020

Changes were made :)

@jxs jxs merged commit 141fae3 into rust-db:master Sep 25, 2020
@jxs
Copy link
Member

jxs commented Sep 25, 2020

thank you! 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning about malformed migration names?
3 participants