Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to create a Config from a string #113

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Added ability to create a Config from a string #113

merged 2 commits into from
Jul 2, 2020

Conversation

GiorgioG
Copy link
Contributor

@GiorgioG GiorgioG commented Jul 2, 2020

  • Added Config::from_str(url_str: &str) Config from a string? #112
  • Refactored Config::from_env_var(...) to call new function (DRY)
  • Fixed 'an URL' grammar to 'a URL'
  • Fixed a typo in a string: 'environemnt' -> 'environment'

GiorgioG added 2 commits July 2, 2020 01:11
@GiorgioG
- Added Config::from_str(url_str: &str)
ad8d4fa 
- Refactored Config::from_env_var(...) to call new function (DRY)
- Fixed 'an URL' grammar to 'a URL'
- Fixed a typo in a string: 'environemnt' -> 'environment'
@GiorgioG
formatting error fix
928b471
@jxs jxs merged commit 38254aa into rust-db:master Jul 2, 2020
@jxs
Copy link
Member

jxs commented Jul 2, 2020

thanks! ❤️

@jxs
Copy link
Member

jxs commented Jul 2, 2020 •
edited
Loading

I have since updated the method to be instead the FromStr trait #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiorgioG @jxs