Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mysql 24.0.0 #291

Closed
raffaeleragni opened this issue Sep 30, 2023 · 3 comments · Fixed by #292
Closed

Support mysql 24.0.0 #291

raffaeleragni opened this issue Sep 30, 2023 · 3 comments · Fixed by #292
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@raffaeleragni
Copy link

Mysql current driver version is 24, but this crate can't compile against it.
@jxs
Copy link
Member

jxs commented Oct 4, 2023

Hi, and thanks for your interest! Care to submit a PR addressing it? See #257 for an example

@jxs jxs added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 4, 2023
@glueball
Copy link
Contributor

glueball commented Nov 8, 2023

Also mysql_async v0.33.

@glueball glueball mentioned this issue Nov 8, 2023
Merged
@glueball
Copy link
Contributor

I've tried to contribute a PR both for mysql v24 and mysql_async v0.33. CI is green. As soon as the maintainers can approve it, Refinery should be good to go with those versions ;)

@jxs jxs closed this as completed in #292 Nov 20, 2023
jxs pushed a commit that referenced this issue Nov 20, 2023
@glueball
#291 Support mysql v24 and mysql_async v0.33. Also update toml. (#292)
0118f01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#291 Support mysql v24 and mysql_async v0.33. Also update toml.
3 participants
@raffaeleragni @jxs @glueball