Set ZIG_COMMAND env var for downstream
#36
Conversation
| @@ -188,7 +188,10 @@ impl Zig { | |||
| } | |||
| } | |||
|
|
|||
| let mut child = Self::command()? | |||
| let mut zig = Self::command()?; | |||
| env::set_var("ZIG_COMMAND", format!("{:?}", zig)); | |||
There was a problem hiding this comment.
It's "zig" or "python3" "-m" "ziglang". I think we should get rid of the double quotes if downstream want to reconstruct a command from it, or leave it as is if downstream just use it to detect whether it's using the pypi version or not.
|
On second thought I think doing this in maturin makes more sense since for Windows MSVC we need to use |
|
I think it is useful to set If someone wants to compile an extension like: The build may fail if MinGW binutils |
|
@ravenexp Moved the code to PyO3/maturin#919 |
No description provided.