Fix hashes version range in 0.29.1 #732
Merged
+27
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use `hashes` in public API and we also use ranged version which makes items accessed through the reexport to break on `cargo update`. We want to remove it eventually, so deprecate it first.
Use of `<= 0.14` was wrong because it would prevent upgrading to 0.14.1+ We expand the range by using `< 0.15` instead.
Rust is now checking cfg attributes for typos but this interferes with our cfgs that rustc/cargo don't recognize. This whitelists them so they no longer produce warnings. This is a backport of 614fe81 because the warnings make development very annoying.
The newest nightly stabilized `PanicMessage` with a slightly different API. This updates the API and removes the `#![feature()]` attribute.
This is a legacy constant and it's better to just use `i32::MAX`. Note that one cannot `use` an associated constant so this just removed the import. This is better anyway since it's only used once and it didn't provide meaningful line length reduction.
bbe8b79 to
f74877a
Compare
apoelstra
reviewed
Sep 6, 2024
| @@ -41,7 +41,7 @@ serde = { version = "1.0.103", default-features = false, optional = true } | |||
|
|
|||
| # You likely only want to enable these if you explicitly do not want to use "std", otherwise enable | |||
| # the respective -std feature e.g., hashes-std | |||
| hashes = { package = "bitcoin_hashes", version = ">= 0.12, <= 0.14", default-features = false, optional = true } | |||
| hashes = { package = "bitcoin_hashes", version = ">= 0.12, < 0.15", default-features = false, optional = true } | |||
There was a problem hiding this comment.
I wonder if Clippy would accept a lint to say that <= [major rev] is likely to be wrong.
There was a problem hiding this comment.
rust-lang/rust-clippy#13362 let's see.
|
Tagged and published. |
|
Tidy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-bitcoin/rust-bitcoin#3296 (comment)