-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: changed Parity serialization to u8 #401
Conversation
* Fixes error message to be according to the trait documentation * Uses `unexpected_value` to provide more information about the error
Serializing the value as `u8` is more compact but this is a breaking change. `Visitor` was renamed to avoid hungarian notation and maybe allow other integers in the future.
4a90c79
to
e6cb588
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK e6cb588
@tcharding your ACK got me to think about this again and maybe we should impl deserialize to suggest deserializing |
My initial thoughts are to not support all integers because there is no real limit to all so what ever subset we support is arbitrary. (I know this argument is a bit contrived.) Is there a use case you can think of where having support for additional integer sizes would be useful? |
We would accept old formats. But really is there any harm accepting |
I don't know if it matters but it would also mean deserialize -> seralize roundtrip will not produce the same output as input. |
Doesn't seem important to me... |
Is this ready for review? |
Ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK e6cb588
Serializing the value as
u8
is more compact but this is a breakingchange.
Visitor
was renamed to avoid hungarian notation and maybe allow otherintegers in the future.
For next major version, depends on #400