Add global context API #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we removed the "global-context-less-secure" a duplicate feature snuck in, remove it.
The global context is already in scope in tests since we use a glob import. No clue why Clippy does not warn for this. Remove unnecessary import statement in test function.
The `from_secret_key` method definition currently uses non-standard indentation. Improve uniformity by using 'standard' indentation.
Our API often involves a `Secp256k1` parameter, when users enable the `global-context` feature they must then pass `SECP256K1` into these functions. This is kind of clunky since the global is by definition available everywhere. Make the API more ergonomic for `global-context` builds by adding various API functions/methods that use the global context implicitly.
apoelstra
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
ACK eb453b8
Strictly additive, ok to merge in a minor revision.
I'm a tiny bit hesitant about this because it reflects a shift in the library's philosophy toward encouraging use of the global context (since these methdos are more convenient than the existing ones) biut I think that this is the direction we're moving in, even upstreatm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our API often involves a
Secp256k1parameter, when users enable theglobal-contextfeature they must then passSECP256K1into these functions. This is kind of clunky since the global is by definition available everywhere.Make the API more ergonomic for
global-contextbuilds by adding various API functions/methods that use the global context implicitly.The first 3 patches are clean up.
Resolves: #330